From 8e700c2b7de7a2bc095ea8edf3204f160f8a8941 Mon Sep 17 00:00:00 2001
From: Loic GUEGAN <loic@Manzerbredes.home>
Date: Sun, 17 Apr 2016 18:42:15 +0200
Subject: [PATCH] Add comments and correct some bugs

---
 client/js/app.js                   |  2 +-
 client/js/controllers/home/home.js | 86 ++++++++++++++----------------
 client/js/controllers/login.js     |  6 ++-
 client/js/controllers/status.js    | 20 ++++---
 client/js/services/Compute.js      |  2 -
 client/partials/home/home.html     | 11 ++--
 6 files changed, 59 insertions(+), 68 deletions(-)

diff --git a/client/js/app.js b/client/js/app.js
index e911050..4ef35b5 100644
--- a/client/js/app.js
+++ b/client/js/app.js
@@ -25,7 +25,7 @@ mainApp.config(['$routeProvider', function($routeProvider){
                 controller: 'imageCtrl'
             })
             .otherwise({
-                redirectTo: '/'
+                redirectTo: '/home'
         });
 }]);
 
diff --git a/client/js/controllers/home/home.js b/client/js/controllers/home/home.js
index 10142c9..7880e12 100755
--- a/client/js/controllers/home/home.js
+++ b/client/js/controllers/home/home.js
@@ -3,58 +3,52 @@
  * 
  * @param {$scope} $scope The $scope service from angular
  */
-mainApp.controller('homeCtrl', [ '$scope', 'Compute', '$rootScope', 'Loading','Identity', 'Image', function ($scope, Compute, $rootScope, Loading, Identity, Image)
-{
+mainApp.controller('homeCtrl', ['$scope', 'Compute', '$rootScope', 'Loading', 'Identity', 'Image', function ($scope, Compute, $rootScope, Loading, Identity, Image)
+    {
 
-	var callMeAfterPullData=function(data){
-                console.log(data);
-		$scope.machines=Compute.getData().machines;
-		Loading.stop();
-	}
+        // Function to call after pull all data about machines
+        var callMeAfterPullData = function (data) {
+            $scope.machines = Compute.getData().machines;
+            Loading.stop();
+        };
 
-	;
-	if(Compute.getData().machines == null && Identity.isAlreadyLogin()){
-		Loading.start();
-		Compute.pullData(callMeAfterPullData);		
-	}
-	else{
-		if(Identity.isAlreadyLogin()){
-			callMeAfterPullData();
-		}
-	}
+        // Function to call to try to retrieve data and update the view
+        var tryToRetrieveData = function () {
+            // If no data retrieve about machine and user is logged
+            if (Compute.getData().machines == null && Identity.isAlreadyLogin()) {
+                Loading.start(); // Show loading gif
+                Compute.pullData(callMeAfterPullData); // Retrieve data and call the callback
+            } else {
+                // Else if user is logged and data is already retrieve
+                // simply display data
+                if (Identity.isAlreadyLogin()) {
+                    callMeAfterPullData(); // Display data
+                }
+            }
+        };
 
 
-	Image.getImages(function(){});
+        // On user login
+        $scope.$on('loginEvent', function () {
+            tryToRetrieveData();
+        });
 
 
 
-	$scope.raiseShowMachineDetailsEvent=function(id){
+        // Function to call from view to display the details of a machine
+        $scope.raiseShowMachineDetailsEvent = function (id) {
 
-		var callback=function(){
-			Loading.stop();
-			var data=Compute.getData();
-			$rootScope.$broadcast("showMachineDetailsEvent", data.machines[id], data.axioms);		
+            // Stop loading gif and display overlay
+            var callback = function () {
+                Loading.stop();
+                var data = Compute.getData();
+                $rootScope.$broadcast("showMachineDetailsEvent", data.machines[id], data.axioms);
 
-		}
-		Loading.start();
-		Compute.pullMachines(callback);
-	}
-
-
-
-
-	
-	if(Identity.isAlreadyLogin()){
-		if(Compute.getData().machines == null){
-			Loading.start();
-			Compute.pullData(callMeAfterPullData);		
-		}
-		   else{
-			   if(Identity.isAlreadyLogin()){
-				   callMeAfterPullData();
-			   }
-		   }
-		   Image.getImages(function(){});
-		  }
-
-}]);
+            };
+            Loading.start(); // Show loading gif
+            Compute.pullMachines(callback); // Retrieve machine info and display overlay
+        };
+        
+        // Try to retrieve data for the first time
+        tryToRetrieveData();
+    }]);
diff --git a/client/js/controllers/login.js b/client/js/controllers/login.js
index 93a373e..4a0de42 100644
--- a/client/js/controllers/login.js
+++ b/client/js/controllers/login.js
@@ -7,7 +7,7 @@
  * @param {Identity} The Identity service
  
  */
-mainApp.controller('loginCtrl', ['$scope', '$sce', 'Identity', function ($scope, $sce, Identity)
+mainApp.controller('loginCtrl', ['$scope', '$sce', 'Identity', '$rootScope', function ($scope, $sce, Identity, $rootScope)
     {
         // Check for login and define default states
         if (!Identity.isAlreadyLogin()) {
@@ -51,12 +51,14 @@ mainApp.controller('loginCtrl', ['$scope', '$sce', 'Identity', function ($scope,
                 } else {
                     // Else the user is online !
                     $('#loginModal').modal('hide');
+                    // Send login event
+                    $rootScope.$broadcast("loginEvent");
                 }
 
                 // Reset button state
                 $('#loginButton').show();
                 $('#loadingLoginButton').hide();
-            }
+            };
 
             // Try to login
             Identity.login(username, password, projectname, responseCallback);
diff --git a/client/js/controllers/status.js b/client/js/controllers/status.js
index 15850f4..c3e634b 100644
--- a/client/js/controllers/status.js
+++ b/client/js/controllers/status.js
@@ -6,16 +6,14 @@
  * @param {$scope} $scope The $scope service from angular
  * @param {Identity} The Identity service
  */
-mainApp.controller('statusCtrl', ['$scope','Identity', '$rootScope', function ($scope, Identity, $rootScope)
-{
+mainApp.controller('statusCtrl', ['$scope', 'Identity', '$rootScope', function ($scope, Identity, $rootScope)
+    {
+        // Give profile to model
+        $scope.profile = Identity.getProfile();
 
-	
-	// Give profile to model
-    $scope.profile=Identity.getProfile();
-	
-    // Function to logout
-    $scope.logout=function(){
-        Identity.logout();
-    };
+        // Function to logout
+        $scope.logout = function () {
+            Identity.logout();
+        };
 
-}]);
+    }]);
diff --git a/client/js/services/Compute.js b/client/js/services/Compute.js
index 2bf28d8..032b402 100644
--- a/client/js/services/Compute.js
+++ b/client/js/services/Compute.js
@@ -101,8 +101,6 @@ mainApp.factory('Compute',[ '$http', 'Identity', function($http, Identity){
 
 		// Wait and handle the response
         result.then(function (response){
-                            alert(Identity.getToken());
-
 			callback(parsePullImagesAnswer(response, false));
         },function(response){
 
diff --git a/client/partials/home/home.html b/client/partials/home/home.html
index f9f8878..11958d2 100644
--- a/client/partials/home/home.html
+++ b/client/partials/home/home.html
@@ -1,12 +1,11 @@
- <div class="panel panel-default" ng-controller="homeCtrl">
+<div class="panel panel-default" ng-controller="homeCtrl">
     <div class="panel-heading">
         Home 
     </div>
     <div class="panel-body">
-        
-		Pour charger les machines, recharger la page (temporaire)<br />
-		Selectionner une machine:
-		<div ng-repeat="machine in machines"> <a ng-click="raiseShowMachineDetailsEvent(machine.id)"> {{ machine.name  }}</a></div>
-		
+
+        Selectionner une machine:
+        <div ng-repeat="machine in machines"> <a ng-click="raiseShowMachineDetailsEvent(machine.id)"> {{ machine.name}}</a></div>
+
     </div>
 </div>