loic/chessarbiter
1
0
Fork 0
mirror of https://gitlab.com/manzerbredes/chessarbiter.git synced 2025-04-06 10:06:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Improve code in general

Browse source
This commit is contained in:
Loic Guegan 2022-12-27 11:28:13 +01:00
parent f9ac11ad44
commit d32baf9894
6 changed files with 18 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/ChessArbiter.cpp
View file

@ -13,9 +13,9 @@ void ChessArbiter::Setup(const std::string &fen) {
positions[this->fen.board] = 1; positions[this->fen.board] = 1;
} }
void ChessArbiter::SetFEN(FEN fen) { SetFEN(FENParser::Serialize(fen)); } void ChessArbiter::SetFEN(const FEN &fen) { SetFEN(FENParser::Serialize(fen)); }
void ChessArbiter::SetFEN(std::string newfen) { void ChessArbiter::SetFEN(const std::string &newfen) {
fen = FENParser::Parse(newfen); fen = FENParser::Parse(newfen);
board.Clear(); board.Clear();

4
src/ChessArbiter.hpp
View file

@ -29,8 +29,8 @@ class ChessArbiter {
/// @brief Use to compute occurences of positions /// @brief Use to compute occurences of positions
std::unordered_map<std::string, char> positions; std::unordered_map<std::string, char> positions;
/// @brief FEN methods used internally /// @brief FEN methods used internally
void SetFEN(std::string); void SetFEN(const std::string &newfen);
void SetFEN(FEN); void SetFEN(const FEN &fen);
std::string SAN, SAN_last; std::string SAN, SAN_last;
char capture; char capture;
bool was_enpassant; bool was_enpassant;

14
src/Fen.cpp
View file

@ -2,9 +2,9 @@
namespace chessarbiter { namespace chessarbiter {
std::string FENParser::normalize_rank(std::string fen_rank) { std::string FENParser::normalize_rank(const std::string &fen_rank) {
std::string normalized; std::string normalized;
for (char &c : fen_rank) { for (const char &c : fen_rank) {
if (IS_DIGIT(c)) { if (IS_DIGIT(c)) {
for (char i = 0; i < (c - '0'); i++) { for (char i = 0; i < (c - '0'); i++) {
normalized += ' '; normalized += ' ';
@ -27,14 +27,14 @@ std::string FENParser::normalize_rank(std::string fen_rank) {
return (normalized); return (normalized);
} }
char FENParser::NextToken(std::string fen, char loc) { char FENParser::NextToken(const std::string &fen, char loc) {
while (loc < fen.size() && IS_BLANK(fen[loc])) { while (loc < fen.size() && IS_BLANK(fen[loc])) {
loc++; loc++;
} }
return (loc); return (loc);
} }
char FENParser::NextRank(std::string fen, char loc) { char FENParser::NextRank(const std::string &fen, char loc) {
loc++; loc++;
while (loc < fen.size() && fen[loc] != '/' && fen[loc] != ' ') { while (loc < fen.size() && fen[loc] != '/' && fen[loc] != ' ') {
loc++; loc++;
@ -42,11 +42,11 @@ char FENParser::NextRank(std::string fen, char loc) {
return (loc); return (loc);
} }
std::string FENParser::Serialize(FEN fen) { std::string FENParser::Serialize(const FEN &fen) {
std::string s; std::string s;
char skip = 0; char skip = 0;
char rank = 0; char rank = 0;
for (char &c : fen.board) { for (const char &c : fen.board) {
rank++; rank++;
if (c == ' ') { if (c == ' ') {
skip++; skip++;
@ -104,7 +104,7 @@ std::string FENParser::Serialize(FEN fen) {
return (s); return (s);
} }
FEN FENParser::Parse(std::string fen) { FEN FENParser::Parse(const std::string &fen) {
FEN parsed; FEN parsed;
// Parse board // Parse board

10
src/Fen.hpp
View file

@ -29,15 +29,15 @@ public:
class FENParser { class FENParser {
private: private:
static std::string normalize_rank(std::string fen_rank); static std::string normalize_rank(const std::string &fen_rank);
static char NextToken(std::string fen, char loc); static char NextToken(const std::string &fen, char loc);
static char NextRank(std::string fen, char loc); static char NextRank(const std::string &fen, char loc);
public: public:
/// @brief Parse a FEN from a string (can throw InvalidFEN) /// @brief Parse a FEN from a string (can throw InvalidFEN)
static FEN Parse(std::string); static FEN Parse(const std::string &fen);
/// @brief Generate a fen string from the FEN object /// @brief Generate a fen string from the FEN object
static std::string Serialize(FEN fen); static std::string Serialize(const FEN &fen);
}; };
struct InvalidFEN : public std::exception { struct InvalidFEN : public std::exception {

2
src/Piece.cpp
View file

@ -1,7 +1,7 @@
#include "Piece.hpp" #include "Piece.hpp"
namespace chessarbiter { namespace chessarbiter {
Piece::Piece(char c, std::string coord) Piece::Piece(char c, const std::string &coord)
: piece(c), isBlack(!isupper(c)), coord(coord) {} : piece(c), isBlack(!isupper(c)), coord(coord) {}
std::vector<std::string> Piece::GetMoves() { std::vector<std::string> Piece::GetMoves() {

2
src/Piece.hpp
View file

@ -19,7 +19,7 @@ public:
bool isBlack; bool isBlack;
std::string coord; std::string coord;
char piece; char piece;
Piece(char c, std::string coord); Piece(char c, const std::string &coord);
/// @brief Get all possible moves according to the type of piece and its position /// @brief Get all possible moves according to the type of piece and its position
std::vector<std::string> GetMoves(); std::vector<std::string> GetMoves();
}; };