loic/chessarbiter
1
0
Fork 0
mirror of https://gitlab.com/manzerbredes/chessarbiter.git synced 2025-04-06 10:06:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Cleaning code

Browse source
This commit is contained in:
Loic Guegan 2022-12-27 10:07:47 +01:00
parent 8238444024
commit bb5d85cb65
2 changed files with 14 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/Board.cpp
View file

@ -2,7 +2,7 @@
namespace chessarbiter { namespace chessarbiter {
bool Board::IsEmpty(std::string coord) { bool Board::IsEmpty(const std::string &coord) {
for (Piece &p : pieces) { for (Piece &p : pieces) {
if (p.coord == coord) { if (p.coord == coord) {
return (false); return (false);
@ -11,7 +11,7 @@ bool Board::IsEmpty(std::string coord) {
return (true); return (true);
} }
bool Board::AddPiece(char p, std::string coord) { bool Board::AddPiece(char p, const std::string &coord) {
if (IsEmpty(coord)) { if (IsEmpty(coord)) {
Piece piece(p, coord); Piece piece(p, coord);
pieces.push_back(piece); pieces.push_back(piece);
@ -20,7 +20,7 @@ bool Board::AddPiece(char p, std::string coord) {
return (false); return (false);
} }
bool Board::RemovePiece(std::string coord) { bool Board::RemovePiece(const std::string &coord) {
for (char i = 0; i < pieces.size(); i++) { for (char i = 0; i < pieces.size(); i++) {
if (pieces[i].coord == coord) { if (pieces[i].coord == coord) {
pieces.erase(pieces.begin() + i); pieces.erase(pieces.begin() + i);
@ -30,7 +30,7 @@ bool Board::RemovePiece(std::string coord) {
return false; return false;
} }
Piece Board::GetPieceAt(std::string coord) { Piece Board::GetPieceAt(const std::string &coord) {
for (Piece &p : pieces) { for (Piece &p : pieces) {
if (p.coord == coord) if (p.coord == coord)
return p; return p;
@ -71,7 +71,7 @@ std::string Board::GetKingLocation(bool isBlack) {
throw NoPieceFound(); throw NoPieceFound();
} }
void Board::Move(std::string move) { void Board::Move(const std::string &move) {
std::string src = move.substr(0, 2); std::string src = move.substr(0, 2);
std::string dst = move.substr(2, 2); std::string dst = move.substr(2, 2);
RemovePiece(dst); // Remove piece on dst if exists RemovePiece(dst); // Remove piece on dst if exists
@ -83,7 +83,7 @@ void Board::Move(std::string move) {
} }
} }
bool Board::IsPieceMoveUnique(char piece, std::string move_dst) { bool Board::IsPieceMoveUnique(char piece, const std::string &move_dst) {
bool isBlack = std::islower(piece); bool isBlack = std::islower(piece);
unsigned char count = 0; unsigned char count = 0;
for (std::string &move : ListPossibleMoves(isBlack)) { for (std::string &move : ListPossibleMoves(isBlack)) {
@ -112,7 +112,7 @@ std::string Board::Serialize() {
return (s); return (s);
} }
bool Board::IsMovePossible(std::string move) { bool Board::IsMovePossible(const std::string &move) {
std::string src = move.substr(0, 2); std::string src = move.substr(0, 2);
std::string dst = move.substr(2, 2); std::string dst = move.substr(2, 2);
if (src == dst) { if (src == dst) {

14
src/Board.hpp
View file

@ -11,28 +11,28 @@ class Board {
public: public:
/// @brief Check if a square is empty /// @brief Check if a square is empty
bool IsEmpty(std::string); bool IsEmpty(const std::string &coord);
/// @brief Add a piece (no checks are performed on coord) /// @brief Add a piece (no checks are performed on coord)
bool AddPiece(char p, std::string); bool AddPiece(char p, const std::string &coord);
/// @brief Remove a piece from a square /// @brief Remove a piece from a square
bool RemovePiece(std::string); bool RemovePiece(const std::string &coord);
/// @brief Get piece at a specific coordinate /// @brief Get piece at a specific coordinate
Piece GetPieceAt(std::string); Piece GetPieceAt(const std::string &coord);
/// @brief Get the pieces of a player /// @brief Get the pieces of a player
std::vector<Piece> GetPlayerPieces(bool); std::vector<Piece> GetPlayerPieces(bool);
/// @brief Count the number of a specific piece on the board /// @brief Count the number of a specific piece on the board
short CountPiece(char); short CountPiece(char);
/// @brief Return true if at most 1 similar piece can go to move_dst /// @brief Return true if at most 1 similar piece can go to move_dst
bool IsPieceMoveUnique(char piece, std::string move_dst); bool IsPieceMoveUnique(char piece, const std::string &move_dst);
/// @brief Get the location of the first king found on the board /// @brief Get the location of the first king found on the board
std::string GetKingLocation(bool); std::string GetKingLocation(bool);
/// @brief Check if a move is technically possible (does not means it is /// @brief Check if a move is technically possible (does not means it is
/// legal) /// legal)
bool IsMovePossible(std::string); bool IsMovePossible(const std::string &move);
/// @brief Clear the board /// @brief Clear the board
void Clear(); void Clear();
/// @brief Move a piece somewhere no matter what /// @brief Move a piece somewhere no matter what
void Move(std::string); void Move(const std::string &move);
/// @brief Get a serialize version of the board /// @brief Get a serialize version of the board
std::string Serialize(); std::string Serialize();
/// @brief List all the technically possible moves of a player /// @brief List all the technically possible moves of a player